Fix Eigen5 support on Pinocchio 3 #2779
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
|
I've added a nix job with eigen 5, without python, casadi & coal. In file included from /build/source/unittest/tridiagonal-matrix.cpp:7:
/build/source/include/pinocchio/math/tridiagonal-matrix.hpp:263:41: error: expected ';' at end of member declaration
263 | EIGEN_CONSTEXPR Eigen::Index rows() const EIGEN_NOEXCEPT
| ^~~~~
| ;
/build/source/include/pinocchio/math/tridiagonal-matrix.hpp:263:47: error: 'EIGEN_NOEXCEPT' does not name a type
263 | EIGEN_CONSTEXPR Eigen::Index rows() const EIGEN_NOEXCEPT
| ^~~~~~~~~~~~~~ |
Random number generation algorithm has changed in Eigen5. Some non robust tests are not passing because of that.
jorisv
requested changes
Oct 21, 2025
jorisv
approved these changes
Oct 21, 2025
|
Casadi support is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to make and fill out this pull request!
Description
Checklist
pre-commit run --all-filesorpixi run lint